Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39116?usp=email ) Change subject: erab_fsm: implement E-RAB MODIFY Req/Rsp procedure ...................................................................... Patch Set 3: (1 comment) File src/erab_fsm.erl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39116/comment/c43f5d0a_b234… : PS3, Line 323: ok I don't see how returning dummy values makes things easier, sorry. This reply becomes a return value for `erab_modify_rsp/2`. It's documented that it can return either `ok` or `{error, ...}`. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39116?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I24d57ea390d71b640cb42046a8658e9d30670682 Gerrit-Change-Number: 39116 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 13 Dec 2024 07:21:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>