Attention is currently required from: pespin.
View Change
1 comment:
File src/erab_fsm.erl:
Patch Set #3, Line 323: ok
probably easier to match upon return if you return {ok, undefined}?
I don't see how returning dummy values makes things easier, sorry. This reply becomes a return value for `erab_modify_rsp/2`. It's documented that it can return either `ok` or `{error, ...}`.
To view, visit change 39116. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I24d57ea390d71b640cb42046a8658e9d30670682
Gerrit-Change-Number: 39116
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Comment-Date: Fri, 13 Dec 2024 07:21:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin@sysmocom.de>