Attention is currently required from: pespin.

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32507 )

Change subject: gmm, rlcmac: Properly handle P-TMSI vs TLLI ......................................................................

Patch Set 2:

(6 comments)

File include/osmocom/gprs/gmm/gmm_prim.h:

https://gerrit.osmocom.org/c/libosmo-gprs/+/32507/comment/cf61356f_90a55b02 PS2, Line 159: none not anymore?

File include/osmocom/gprs/rlcmac/rlcmac_prim.h:

https://gerrit.osmocom.org/c/libosmo-gprs/+/32507/comment/ca0d6267_cf6aa8b1 PS2, Line 82: none not anymore?

https://gerrit.osmocom.org/c/libosmo-gprs/+/32507/comment/b538a358_c33f501c PS2, Line 195: uint32_t old_tlli, uint32_t new_tlli); This is one of the reasons why I don't like that there is no generic prim alloc function: once we have the first release, adding new fields like this would not be possible, we would have to deprecate old API and add `foo2()`, `foo3()`, etc.

File src/gmm/gmm.c:

https://gerrit.osmocom.org/c/libosmo-gprs/+/32507/comment/8670a646_71e2d11f PS2, Line 260: goto restart If this was not your patch, I would expect you to be the first one to comment here and say that `do { ... } while(...)` would be cleaner. Is there a reason to not use do-while?

File src/gmm/gmm_prim.c:

https://gerrit.osmocom.org/c/libosmo-gprs/+/32507/comment/d31ff806_b9be6ad6 PS2, Line 420: gmme = gprs_gmm_gmme_find_or_create_by_ptmsi_imsi(gmm_prim->gmmsm.establish_req.ptmsi, no `OSMO_ASSERT` like above?

File tests/gmm/Makefile.am:

https://gerrit.osmocom.org/c/libosmo-gprs/+/32507/comment/9ba9293f_a7831fb3 PS2, Line 36: $(NULL) " No newline at end of right file. "