Attention is currently required from: pespin.

View Change

6 comments:

• File include/osmocom/gprs/gmm/gmm_prim.h:

  • Patch Set #2, Line 159: none

    not anymore?

• File include/osmocom/gprs/rlcmac/rlcmac_prim.h:

  • Patch Set #2, Line 82: none

    not anymore?

  • Patch Set #2, Line 195: uint32_t old_tlli, uint32_t new_tlli);

    This is one of the reasons why I don't like that there is no generic prim alloc function: once we have the first release, adding new fields like this would not be possible, we would have to deprecate old API and add `foo2()`, `foo3()`, etc.

• File src/gmm/gmm.c:

  • Patch Set #2, Line 260: goto restart

    If this was not your patch, I would expect you to be the first one to comment here and say that `do { ... } while(...)` would be cleaner. Is there a reason to not use do-while?

• File src/gmm/gmm_prim.c:

  • Patch Set #2, Line 420: gmme = gprs_gmm_gmme_find_or_create_by_ptmsi_imsi(gmm_prim->gmmsm.establish_req.ptmsi,

    no `OSMO_ASSERT` like above?

• File tests/gmm/Makefile.am:

  • Patch Set #2, Line 36: $(NULL)

    " No newline at end of right file. "

To view, visit change 32507. To unsubscribe, or for help writing mail filters, visit settings.