Attention is currently required from: msuraev, dexter. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31362 ) Change subject: pcu_l1_if: get rid of l1if checks ...................................................................... Patch Set 4: Code-Review-1 (1 comment) Patchset: PS4: sorry, i think this patch is going the wrong way. If a PHY is being set up with phy L1 callbacks, then its l1 context object being NULL is not plausible. I mean, the phy implementation should not check in every single function that its context pointer is non-NULL. It has been set up, that is why its callbacks are being called. It also does not seem very plausible that there is a TRX set up on a NULL PHY ... if these NULL checks should happen at all, they seem more fit in the places where they were before this patch .. or they can be dropped completely, AFAICT. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31362 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I54c5de04382e0bd0dbbf233eaffb403fc492d070 Gerrit-Change-Number: 31362 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Feb 2023 00:51:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment