Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31969 )
Change subject: l1gprs: fix NULL pointer dereference in l1gprs_unregister_tbf() ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/shared/l1gprs.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/31969/comment/99780fc7_7bb861cf PS1, Line 138: "%s(): " LOG_TBF_FMT " not found\n",
No, this is correct. I am passing the format string arguments expected by `LOG_TBF_FMT` manually.
Yes but my point is that passing that LOG_TBF_FMT here makes the code more difficult to understand because you are not sure what you pass matches with what you have in the macro until you look at it.