Attention is currently required from: fixeria.

Patch set 1:Code-Review +1

View Change

1 comment:

• File src/shared/l1gprs.c:

  • Patch Set #1, Line 138: "%s(): " LOG_TBF_FMT " not found\n",

    No, this is correct. I am passing the format string arguments expected by `LOG_TBF_FMT` manually.

    Yes but my point is that passing that LOG_TBF_FMT here makes the code more difficult to understand because you are not sure what you pass matches with what you have in the macro until you look at it.

To view, visit change 31969. To unsubscribe, or for help writing mail filters, visit settings.