Attention is currently required from: daniel, neels, pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39316?usp=email )
Change subject: stream: Introduce osmo_stream_{cli,srv}_set_segmentation_cb2 ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2: I am wondering if there's another alternative that we can do this without introducing the clumsy *2() API workaround... like passing the data via msgb->cb? or maybe even better msg->dst? If it's an optional feature that the calling application can enable via some osmo_stram_srv_enable_segmentation_callback_dst() or the like, then we also have no risk of overwriting msgb fileds that are actually in use.
But even that is unlikely. I would argue in the segmentation_cb none of those msgb fields are used for anything yet, as the msgb hasn't even been officially passed into the application yet.