Attention is currently required from: laforge, fixeria.

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33690 )

Change subject: pySim/cards: Split legacy classes away from core SIM + UICC ......................................................................

Patch Set 5:

(1 comment)

File pySim/cards.py:

https://gerrit.osmocom.org/c/pysim/+/33690/comment/9ae38531_887226bc PS4, Line 319: SimCard

indeed. […]

I personally would put a comment into UiccCardBase that describes the situation. I would try to avoid the code dup for now since it also looks strange. Should we later add more classic SIM specific code to SimCardBase that technically wouldn't fit into UiccCardBase, then I would think about changing it. (but I think that is unlikely.)