Attention is currently required from: laforge, fixeria.
View Change
1 comment:
File pySim/cards.py:
Patch Set #4, Line 319: SimCard
indeed. […]
I personally would put a comment into UiccCardBase that describes the situation. I would try to avoid the code dup for now since it also looks strange. Should we later add more classic SIM specific code to SimCardBase that technically wouldn't fit into UiccCardBase, then I would think about changing it. (but I think that is unlikely.)
To view, visit change 33690. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Id36140675def5fc44eedce81fc7b09e0adc527e1
Gerrit-Change-Number: 33690
Gerrit-PatchSet: 5
Gerrit-Owner: laforge <laforge@osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Comment-Date: Mon, 17 Jul 2023 15:52:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge@osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>
Gerrit-MessageType: comment