Attention is currently required from: pespin.
daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40290?usp=email )
Change subject: sccp: Improve spec references in code documentation ......................................................................
Patch Set 1:
(1 comment)
File src/sccp_scrc.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/40290/comment/5db70781_54792f... : PS1, Line 245: /* "Figure C.1/Q.714 - SCCP routing control procedures (SCRC) (sheet 5 of 12)" Not sure if that's too pedantic, but could you change it to
``` /* ITU Q.714: Figure X.Y ``` (and below as well)?
It wasn't clear to me what the spec was so I scrolled all the way to the top of the file to find it's Q.714. That's also how I found an existing comment (in the proposed format) in line 65.