Attention is currently required from: osmith.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/35075?usp=email )
Change subject: Use 'iuh/local-ip' as local IP for RTP sockets ......................................................................
Patch Set 2:
(1 comment)
File src/osmo-hnodeb/rtp.c:
https://gerrit.osmocom.org/c/osmo-hnodeb/+/35075/comment/e35133bc_44e59877 PS2, Line 335: }
maybe add an else path here that logs an error and goes to free_ret?
why/where / what should that clause do? The existing code in rtp_get_bound_addr "does the right thing" for local INADDR_ANY/IN6ADDR_ANY. In all other cases, conn->loc_addr already contains a specific local address and hence there's nothing to do.