Attention is currently required from: neels.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39248?usp=email )
Change subject: mgw: Decouple SDP parsing step from conn obj update ......................................................................
Patch Set 3:
(3 comments)
File include/osmocom/mgcp/mgcp_protocol.h:
https://gerrit.osmocom.org/c/osmo-mgw/+/39248/comment/30f2ff15_0ee7efcd?usp=... : PS3, Line 13: #define MGCP_PARSE_SDP_MAXPTIME_UNSET (-1)
duplicate -1
It's not duplicate, it's two different fields.
https://gerrit.osmocom.org/c/osmo-mgw/+/39248/comment/8c2af996_f6210744?usp=... : PS3, Line 14: #define MGCP_PARSE_SDP_RTP_PORT_UNSET (0)
(i prefer enums)
It's not a closed set of values, but a specific value in an int range, it's fine as a define.
File src/libosmo-mgcp/mgcp_protocol.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/39248/comment/025b22e4_0b6d85b1?usp=... : PS3, Line 1139: if (rc < 0) { /* See also RFC 3661: Protocol error */
(comments deserve their own separate line plz)
I'm actually fine with it the current way, but changing in to avoid discussions.
-
pespin