pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/39346?usp=email )

Change subject: osmo_io: Increase default queue max_length from 32 to 1024 ......................................................................

osmo_io: Increase default queue max_length from 32 to 1024

The default value is way too low, and can be hit easily by apps submitting several messages in one main loop run. This is the case for instance of the Abis OML protocol, where a cascade of "State Changed Event Reports" are sent for the whole object tree.

Set the default to a saner bigger value. In the end, increasing the value doesn't hurt normal use of apps, and 1024 is still a fairly small number to avoid the app eating the whole system memory if something unexpected happens.

Change-Id: I92d5369af523f6297d45d4b534bb0f349ae74485 (cherry picked from commit 9cbc92e80e8a70131851b363c4438c216e559335) --- M src/core/osmo_io.c 1 file changed, 2 insertions(+), 2 deletions(-)

Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified neels: Looks good to me, but someone else must approve

diff --git a/src/core/osmo_io.c b/src/core/osmo_io.c index af096e6..98d8ef3 100644 --- a/src/core/osmo_io.c +++ b/src/core/osmo_io.c @@ -637,7 +637,7 @@ * The created osmo_io_fd is initialized with some default settings: * * msgb allocations size: OSMO_IO_DEFAULT_MSGB_SIZE (1024) * * msgb headroom: OSMO_IO_DEFAULT_MSGB_HEADROOM (128) - * * tx_queue depth: 32 + * * tx_queue depth: 1024 * * Those values may be adjusted from their defaults by using osmo_iofd_set_alloc_info() and * osmo_iofd_set_txqueue_max_length() on the osmo_io_fd. @@ -696,7 +696,7 @@ iofd->msgb_alloc.size = OSMO_IO_DEFAULT_MSGB_SIZE; iofd->msgb_alloc.headroom = OSMO_IO_DEFAULT_MSGB_HEADROOM;

- iofd->tx_queue.max_length = 32; + iofd->tx_queue.max_length = 1024; INIT_LLIST_HEAD(&iofd->tx_queue.msg_queue);

return iofd;