Attention is currently required from: daniel, laforge.

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39287?usp=email )

Change subject: server: Support storing of pcapng format ......................................................................

Patch Set 5:

(2 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-pcap/+/39287/comment/42739e69_1946850e?usp... : PS5, Line 13: This requires, during LINK_HDR when file header is received, discering

discering? do you mean distinguishing?

I meant discerning, will fix https://dictionary.cambridge.org/dictionary/english/discern

File src/osmo_server_network.c:

https://gerrit.osmocom.org/c/osmo-pcap/+/39287/comment/c9b1deeb_a8c7f19c?usp... : PS5, Line 352: BLOCK_TYPE_SHB

why LOGL_DEBUG here vs LOGL_ERROR above for the other implausible things?

This is wrong, I'll fix, thanks.