Attention is currently required from: laforge, lynxis lazus.

fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38397?usp=email )

Change subject: SGSN: BSSGP_ConnHdlr: GMM Service Request: handle PMM IDLE UE correct ......................................................................

Patch Set 4:

(2 comments)

File sgsn/BSSGP_ConnHdlr.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38397/comment/c1b417e4_66f8d... : PS4, Line 629: setverdict(fail, "Unexpected Service Reject"); Should we still fail here if the API user passes `exp_service_acc := false`?

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38397/comment/e234902d_74a40... : PS4, Line 640: } else { So in the case of `exp_service_acc := false`, this altstep repeats and will keep waiting for what kind of event? We will never catch `tr_GMM_SERVICE_ACC` because of the guard statement you're adding, and receiving `tr_GMM_SERVICE_REJ` would cause the testcase to fail. I am trying to understand the logic...