fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37219?usp=email )

Change subject: logging: convert error_logger:error_report/1 to ?LOG_ERROR ......................................................................

logging: convert error_logger:error_report/1 to ?LOG_ERROR

In Erlang/OTP 21.0, a new API for logging was added. The old error_logger module can still be used by legacy code, but log events are redirected to the new Logger API. New code should use the Logger API directly.

Change-Id: Id6c61fb5ca730209ef625fc5f63d627574e60fbe --- M src/sctp_server.erl 1 file changed, 17 insertions(+), 7 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/19/37219/1

diff --git a/src/sctp_server.erl b/src/sctp_server.erl index 5c73fc2..2c3893a 100644 --- a/src/sctp_server.erl +++ b/src/sctp_server.erl @@ -93,9 +93,8 @@ mme_addr_port = MmeAddrPort}}.

-handle_call(Info, _From, State) -> - error_logger:error_report(["unknown handle_call()", - {module, ?MODULE}, {info, Info}, {state, State}]), +handle_call(Info, From, State) -> + ?LOG_ERROR("unknown ~p() from ~p: ~p", [?FUNCTION_NAME, From, Info]), {reply, {error, not_implemented}, State}.

@@ -107,8 +106,7 @@ {noreply, State};

handle_cast(Info, State) -> - error_logger:error_report(["unknown handle_cast()", - {module, ?MODULE}, {info, Info}, {state, State}]), + ?LOG_ERROR("unknown ~p(): ~p", [?FUNCTION_NAME, Info]), {noreply, State}.

@@ -132,8 +130,7 @@

%% Catch-all for unknown messages handle_info(Info, State) -> - error_logger:error_report(["unknown handle_info()", - {module, ?MODULE}, {info, Info}, {state, State}]), + ?LOG_ERROR("unknown ~p(): ~p", [?FUNCTION_NAME, Info]), {noreply, State}.