Attention is currently required from: msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30972 )

Change subject: layer23: Move '(no) shutdown' VTY code to common/vty.c ......................................................................

Patch Set 2:

(2 comments)

File doc/examples/modem/modem.cfg:

https://gerrit.osmocom.org/c/osmocom-bb/+/30972/comment/2348c5e3_d26098dd PS2, Line 1: !

Unrelated change?

It's not unrelated. modem now starts needing a vty to set the "no shutdown" command (even if internally some of the implementation doesn't care about it, but it will, like mobile app).

File src/host/layer23/include/osmocom/bb/common/osmocom_data.h:

https://gerrit.osmocom.org/c/osmocom-bb/+/30972/comment/0f3f2276_b962544f PS2, Line 37: struct osmobb_l23_vty_sig_data {

Why separate substructs for start/stop? The commands using them are mutually exclusive so single 'st […]

because more commands will probably be added later. I missed adding those in a union though, I'll update the commit adding a union.