Attention is currently required from: laforge, pespin.
fixeria has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/osmo-bsc/+/38127?usp=email )
Change subject: Introduce hashtable to lookup bts by <LAC,CI>
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File include/osmocom/bsc/gsm_data.h:
https://gerrit.osmocom.org/c/osmo-bsc/+/38127/comment/9718e770_3b2f4abe?usp… :
PS2, Line 993: #define LAC_CI_HASHTABLE_KEY(lac, ci) ((((uint32_t)(ci)) <<
sizeof(lac)) | (uint32_t)(lac))
Ah ok, I did it this way on purpose to align it as if
it was a function of the class, but I can modi […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/38127?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I47db6c7543e5c6c3b8f0de3ae5ee1b53c2b5f16f
Gerrit-Change-Number: 38127
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 16 Sep 2024 10:32:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>