Attention is currently required from: neels.
fixeria has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39741?usp=email )
Change subject: [1/7] personalization: refactor: drop ClassVarMeta use ......................................................................
Patch Set 4:
(2 comments)
File pySim/esim/saip/personalization.py:
https://gerrit.osmocom.org/c/pysim/+/39741/comment/89006f02_7a8d2745?usp=ema... : PS4, Line 61: @abc.abstractmethod Why are you removing this? The COMMIT_MSG says you're dropping `ClassVarMeta`, but you're also removing abstract class/method qualifiers. This is still an abstract method, that must be implemented by derived classes, isn't it?
https://gerrit.osmocom.org/c/pysim/+/39741/comment/5485987c_5061b1ec?usp=ema... : PS4, Line 147: class SdKeyScp80_01(SdKey, kvn=0x01, key_type=0x88, permitted_len=[16,24,32]): # AES key type IMO, the old approach is much more compact and thus more readable.
-
fixeria