Attention is currently required from: neels.

View Change

2 comments:

• File pySim/esim/saip/personalization.py:

  • Patch Set #4, Line 61: @abc.abstractmethod

    Why are you removing this? The COMMIT_MSG says you're dropping `ClassVarMeta`, but you're also removing abstract class/method qualifiers. This is still an abstract method, that must be implemented by derived classes, isn't it?

  • Patch Set #4, Line 147: class SdKeyScp80_01(SdKey, kvn=0x01, key_type=0x88, permitted_len=[16,24,32]): # AES key type

    IMO, the old approach is much more compact and thus more readable.

To view, visit change 39741. To unsubscribe, or for help writing mail filters, visit settings.