Attention is currently required from: neels, fixeria.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31811 )

Change subject: bscc_sccp: Small optimiztion in bsc_sccp_inst_next_conn_id() ......................................................................

Patch Set 1:

(1 comment)

File src/osmo-bsc/bsc_sccp.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/31811/comment/c84d8de7_aa055288 PS1, Line 55: next_id = (next_id + 1) & 0x00FFFFFF;

Looks like you can simply do: `(next_id + 1) % 0x00FFFFFF`? […]

I'm not sure doing thousands of modulo operations is actually better than doing an bitwise AND plus a CMP. I could add OSMO_UNLIKELY() around "if (next_id == 0x00FFFFFF)"

It is totally possible, since i is range 0..0x00FFFFFE, but next_id may start being any number in that range, so most of the times it will wrap around.