Attention is currently required from: neels, fixeria.

View Change

1 comment:

• File src/osmo-bsc/bsc_sccp.c:

  • Patch Set #1, Line 55: next_id = (next_id + 1) & 0x00FFFFFF;

    Looks like you can simply do: `(next_id + 1) % 0x00FFFFFF`? […]

    I'm not sure doing thousands of modulo operations is actually better than doing an bitwise AND plus a CMP. I could add OSMO_UNLIKELY() around "if (next_id == 0x00FFFFFF)"

    It is totally possible, since i is range 0..0x00FFFFFE, but next_id may start being any number in that range, so most of the times it will wrap around.

To view, visit change 31811. To unsubscribe, or for help writing mail filters, visit settings.