Attention is currently required from: fixeria.
laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/39829?usp=email )
Change subject: rsl: rsl_rx_chan_activ(): set TA=0 if not indicated by the BSC ......................................................................
Patch Set 1:
(1 comment)
File src/common/rsl.c:
https://gerrit.osmocom.org/c/osmo-bts/+/39829/comment/e19c083a_c9ae185a?usp=... : PS1, Line 2068: lchan->ta_ctrl.current = 0; it's a bit of a question whether we expect all of those valuse to be zero or otherwise sanely default-initialized when we start using a lchan or not. My preference would be to re-set the ta_ctrl.current to zero during LCHAN release/deactivation.
If you want to do it here, then why are we not also setting ms_power_ctrl.{max,current} if the RSL_IE_MS_POWER is not presetn? opr many other parts of this function...