Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38195?usp=email ) Change subject: filesystem: pass total_len to construct of when encoding file contents ...................................................................... Patch Set 2: (2 comments) File pySim/filesystem.py: https://gerrit.osmocom.org/c/pysim/+/38195/comment/e2ac5f02_73b350c9?usp=em… : PS1, Line 1043: __get_rec_len Done https://gerrit.osmocom.org/c/pysim/+/38195/comment/4a36e838_555088b7?usp=em… : PS1, Line 1266: return b2h(filter_dict(build_construct(self._construct, abstract_data, self._get_size(total_len)))) The current purpose of the TransRecEF is that our _construct only needs to specify the encoding of a single record, instead of N* a record over the entire file. The shell commands are still read_binary / update_binary as IMHO it would be too confusing to have record-oriented shell commands on a transparent file. That could of course be done, but it's not how the current code works. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38195?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I1b7a51594fbc5d9fe01132c39354a2fa88d53f9b Gerrit-Change-Number: 38195 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 19 Sep 2024 12:33:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>