Attention is currently required from: dexter.

laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38195?usp=email )

Change subject: filesystem: pass total_len to construct of when encoding file contents ......................................................................

Patch Set 2:

(2 comments)

File pySim/filesystem.py:

https://gerrit.osmocom.org/c/pysim/+/38195/comment/e2ac5f02_73b350c9?usp=ema... : PS1, Line 1043: __get_rec_len

I have put the double underscore to make the method as private. […]

Done

https://gerrit.osmocom.org/c/pysim/+/38195/comment/4a36e838_555088b7?usp=ema... : PS1, Line 1266: return b2h(filter_dict(build_construct(self._construct, abstract_data, self._get_size(total_len))))

I still not seeing entirely through here. […]

The current purpose of the TransRecEF is that our _construct only needs to specify the encoding of a single record, instead of N* a record over the entire file. The shell commands are still read_binary / update_binary as IMHO it would be too confusing to have record-oriented shell commands on a transparent file. That could of course be done, but it's not how the current code works.