Attention is currently required from: fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/27885
)
Change subject: paging: Submit up to 20 paging requests in a single work iteration
......................................................................
Patch Set 4:
(2 comments)
File src/osmo-bsc/paging.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27885/comment/75bb8b1c_48af21b7
PS3, Line 243: } while (request != initial_request && num_paged <
MAX_PAGE_REQ_PER_ITER);
I am trying to understand how this is supposed to work
if you have less than 20 penging requests awa […]
If we have two: [A, B]
initial_request = A
request = A
do {
...
llist_del + llist_add_tail: [B, A]
request = B
while (request != initial_request) -> B != A, we do next iteration with B:
do {
...
llist_del + llist_add_tail: [A, B]
request = A
while (request != initial_request) -> A != A, not true, we break.
https://gerrit.osmocom.org/c/osmo-bsc/+/27885/comment/154d1e57_0fc418b6
PS3, Line 246: sched_next_paging
This label name is confusing: when I saw the
'goto' above I thought you're somehow scheduling/sendin […]
ok I'll
change it to sched_next_iter. "skip_paging" didn't look good to me, since
sometimes it's not really skipping, but actually re-scheduling.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/27885
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I609fa67834b426456f48f6fb2acb601c5905f178
Gerrit-Change-Number: 27885
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 25 Apr 2022 09:58:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment