Attention is currently required from: fixeria.

View Change

2 comments:

• File src/osmo-bsc/paging.c:

  • Patch Set #3, Line 243: } while (request != initial_request && num_paged < MAX_PAGE_REQ_PER_ITER);

    I am trying to understand how this is supposed to work if you have less than 20 penging requests awa […]

    If we have two: [A, B]
    initial_request = A
    request = A
    do {
    ...
    llist_del + llist_add_tail: [B, A]
    request = B
    while (request != initial_request) -> B != A, we do next iteration with B:
    do {
    ...
    llist_del + llist_add_tail: [A, B]
    request = A
    while (request != initial_request) -> A != A, not true, we break.

  • Patch Set #3, Line 246: sched_next_paging

    This label name is confusing: when I saw the 'goto' above I thought you're somehow scheduling/sendin […]

    ok I'll change it to sched_next_iter. "skip_paging" didn't look good to me, since sometimes it's not really skipping, but actually re-scheduling.

To view, visit change 27885. To unsubscribe, or for help writing mail filters, visit settings.