Attention is currently required from: fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-sccp/+/35253?usp=email )
Change subject: vty: show cs7 instance asp: Swap columns SCTP Role and Remote Address
list
......................................................................
Patch Set 3:
(2 comments)
File TODO-RELEASE:
https://gerrit.osmocom.org/c/libosmo-sccp/+/35253/comment/73bfe161_28e9dec3
PS3, Line 12: .
(can be squashed into the previous patch, but not
critical)
I preferred keeping it separate.
File tests/vty/ss7_asp_test.vty:
https://gerrit.osmocom.org/c/libosmo-sccp/+/35253/comment/c0c3486d_255985b3
PS3, Line 262:
Hmm, is this ws printed by the API?
yes, like in
many other cmds where line formatting is used, to keep the columns.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-sccp/+/35253?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I4854219f8898266ae47b9117ef79dbad30a5b0fd
Gerrit-Change-Number: 35253
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 12 Dec 2023 15:05:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment