Attention is currently required from: jolly.

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34614?usp=email )

Change subject: ASCI: Add decoding of SYSTEM INFORMATION TYPE 10 $(ASCI)$ ......................................................................

Patch Set 1:

(6 comments)

Patchset:

PS1: Looks good to me in general, just a few minor things.

File src/host/layer23/src/common/sysinfo.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/34614/comment/85cd51e0_d0964617 PS1, Line 613: Band indicator `BA_IND` is actually BCCH allocation sequence number indication, and not a band indicator? The logging message does not have to explain the meaning, so it could be just `SI10: BA_IND %u != BA_IND %u of SI5!\n`.

https://gerrit.osmocom.org/c/osmocom-bb/+/34614/comment/e4f2566c_3d93d91d PS1, Line 632: parameter parameter(s)

https://gerrit.osmocom.org/c/osmocom-bb/+/34614/comment/ce1dcd1c_cc6c4ba0 PS1, Line 639: return 0; AFAICS if the first cell is barred, we stop decoding the first part but still proceed with decoding the rest because return value `!= EOF`.

https://gerrit.osmocom.org/c/osmocom-bb/+/34614/comment/5ff56131_93b32ef6 PS1, Line 651: bitvec_get_uint(bv, 6) - 110 use `rxlev2dbm()`

https://gerrit.osmocom.org/c/osmocom-bb/+/34614/comment/0b4a496a_693c9f05 PS1, Line 1091: puts debugging leftovers?