Attention is currently required from: jolly.

View Change

6 comments:

• Patchset:

  • Patch Set #1:

    Looks good to me in general, just a few minor things.

• File src/host/layer23/src/common/sysinfo.c:

  • Patch Set #1, Line 613: Band indicator

    `BA_IND` is actually BCCH allocation sequence number indication, and not a band indicator? The logging message does not have to explain the meaning, so it could be just `SI10: BA_IND %u != BA_IND %u of SI5!\n`.

  • Patch Set #1, Line 632: parameter

    parameter(s)

  • Patch Set #1, Line 639: return 0;

    AFAICS if the first cell is barred, we stop decoding the first part but still proceed with decoding the rest because return value `!= EOF`.

  • Patch Set #1, Line 651: bitvec_get_uint(bv, 6) - 110

    use `rxlev2dbm()`

  • Patch Set #1, Line 1091: puts

    debugging leftovers?

To view, visit change 34614. To unsubscribe, or for help writing mail filters, visit settings.