[S] Change in osmo-sgsn[master]: libgtp: Check for all successful create_pdp_conf causes - gerrit-log

23 Nov 2023


      Attention is currently required from: laforge, lynxis lazus.
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/35094?usp=email )
The change is no longer submittable: Code-Review is unsatisfied now.
Change subject: libgtp: Check for all successful create_pdp_conf causes
......................................................................
Patch Set 2: Code-Review-2
(1 comment)
File src/sgsn/sgsn_libgtp.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/35094/comment/7fd2de4e_82e04695 
PS2, Line 420: 	if (gtp_cause_successful(cause)) {
true is false ☯
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/35094?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I11ce72908c2dfb983887e6c1db316fd7de42f027
Gerrit-Change-Number: 35094
Gerrit-PatchSet: 2
Gerrit-Owner: daniel dwillmann@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel dwillmann@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: lynxis lazus lynxis@fe80.eu
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: lynxis lazus lynxis@fe80.eu
Gerrit-Comment-Date: Thu, 23 Nov 2023 16:58:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment