[S] Change in osmo-msc[master]: libmsc: reset the LU delay timer (X36) on MO/MT SMS - gerrit-log

28 May 2024

Attention is currently required from: laforge, neels.

fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-msc/+/36865?usp=email )

Change subject: libmsc: reset the LU delay timer (X36) on MO/MT SMS
......................................................................

Patch Set 3:

(1 comment)

File src/libmsc/gsm_04_11.c:

https://gerrit.osmocom.org/c/osmo-msc/+/36865/comment/5b5b77c8_63a84c67 
PS3, Line 1089: 			msc_a_put(msc_a, MSC_A_USE_LOCATION_UPDATING);
...
  if the MS has 3 SMS waiting, is it possible that this
cuts off the conn after the first SMS is done, and before SMS 2 and 3 have happened?

No, there exists `MMTS` flag to prevent this, which is indicating that the network has
More Messages (MT RPDUs) To Send. Grep for `MSC_A_USE_SMS_MMTS` and/or check out 3GPP TS
24.011.

...
  (hehe, with this patch, a LU with a pending SMS will
release faster than one without an SMS... by far the most LU will be periodic without any
SMS pending, so this optimization is pretty marginal in practice, right? I wonder if we
should maybe reduce the complexity and not add this patch?) 
First of all, this was specifically requested by the customer. I don't see much
complexity here, and I think it's still makes sense to merge this patch. As I said,
not delaying periodic LU connections can be implemented later.

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/36865?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Iad4ace6038be4b6037e341e7d9d187bef2917d80
Gerrit-Change-Number: 36865
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Reviewer: neels &lt;nhofmeyr(a)sysmocom.de&gt;
Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Attention: neels &lt;nhofmeyr(a)sysmocom.de&gt;
Gerrit-Attention: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Comment-Date: Tue, 28 May 2024 21:31:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels &lt;nhofmeyr(a)sysmocom.de&gt;
Gerrit-MessageType: comment