Attention is currently required from: laforge, neels.

View Change

1 comment:

• File src/libmsc/gsm_04_11.c:

  • Patch Set #3, Line 1089: msc_a_put(msc_a, MSC_A_USE_LOCATION_UPDATING);

    if the MS has 3 SMS waiting, is it possible that this cuts off the conn after the first SMS is done, and before SMS 2 and 3 have happened?

    No, there exists `MMTS` flag to prevent this, which is indicating that the network has More Messages (MT RPDUs) To Send. Grep for `MSC_A_USE_SMS_MMTS` and/or check out 3GPP TS 24.011.

    (hehe, with this patch, a LU with a pending SMS will release faster than one without an SMS... by far the most LU will be periodic without any SMS pending, so this optimization is pretty marginal in practice, right? I wonder if we should maybe reduce the complexity and not add this patch?)

    First of all, this was specifically requested by the customer. I don't see much complexity here, and I think it's still makes sense to merge this patch. As I said, not delaying periodic LU connections can be implemented later.

To view, visit change 36865. To unsubscribe, or for help writing mail filters, visit settings.