Attention is currently required from: neels.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/31698 )

Change subject: [codecs filter] send + receive SDP via MNCC ......................................................................

Patch Set 3:

(4 comments)

File src/libmsc/gsm_04_08_cc.c:

https://gerrit.osmocom.org/c/osmo-msc/+/31698/comment/fa703bdc_dcd929f3 PS3, Line 633: codec_filter_run(&trans->cc.codecs); You are already calling codec_filter_run in line 621, why calling this again here?

https://gerrit.osmocom.org/c/osmo-msc/+/31698/comment/0691b10a_6c2749c3 PS3, Line 935: codec_filter_run(&trans->cc.codecs); as usual, why is filter_run called here? is new_cc_state() changing it?

https://gerrit.osmocom.org/c/osmo-msc/+/31698/comment/f0c76022_3b15e188 PS3, Line 973: codec_filter_run(&trans->cc.codecs); in here it makes sense to call _run() because you are calling set_remote() before? Or actually it has nothing to do with filtering codecs here.

https://gerrit.osmocom.org/c/osmo-msc/+/31698/comment/57c0c86e_ef938ba3 PS3, Line 1084: codec_filter_run(&trans->cc.codecs); same ehre, why is all full of codec_filter_run?