Attention is currently required from: neels.

View Change

4 comments:

• File src/libmsc/gsm_04_08_cc.c:

  • Patch Set #3, Line 633: codec_filter_run(&trans->cc.codecs);

    You are already calling codec_filter_run in line 621, why calling this again here?

  • Patch Set #3, Line 935: codec_filter_run(&trans->cc.codecs);

    as usual, why is filter_run called here? is new_cc_state() changing it?

  • Patch Set #3, Line 973: codec_filter_run(&trans->cc.codecs);

    in here it makes sense to call _run() because you are calling set_remote() before? Or actually it has nothing to do with filtering codecs here.

  • Patch Set #3, Line 1084: codec_filter_run(&trans->cc.codecs);

    same ehre, why is all full of codec_filter_run?

To view, visit change 31698. To unsubscribe, or for help writing mail filters, visit settings.