Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32685 )
Change subject: codec: replace GSM-FR ECU with new implementation ......................................................................
Patch Set 1:
(2 comments)
File src/codec/ecu_fr.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-6937): https://gerrit.osmocom.org/c/libosmocore/+/32685/comment/41e9f3ce_cadb8a42 PS1, Line 202: } else { else is not generally useful after a break or return
File src/codec/ecu_fr_old.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-6937): https://gerrit.osmocom.org/c/libosmocore/+/32685/comment/25dee732_f03df542 PS1, Line 145: * \returns 0 if the frame was sucessfully filled 'sucessfully' may be misspelled - perhaps 'successfully'?
-
Jenkins Builder