Attention is currently required from: lynxis lazus, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37924?usp=email ) Change subject: s1ap_proxy: Support replying errors ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: I did not expect my request to trigger such an emotional burst... I do understand your frustration, but this patch introduces significant changes to the core part of the S1GW (the proxy), so this is why I am worried about testing coverage and this is why I am so picky. And TBH, I still don't see how the metrics patch depends on this one and why are they both in the same patch set. This is true, and I acknowledge that the Heartbeat related patches have been merged without the respective TTCN-3 testing coverage. I started working on it, but got swallowed by design/implementation of problems with the PFCP Emulation component. I just pushed a patchset fixing the emulation component and adding the Heartbeat test: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38037 s1gw: add TC_pfcp_heartbeat I am working on improving the TTCN-3 testsuite. Yes, the progress is slow, but as you know I am not a full time employee and I am working less hours then you. Even worse, I was side tracked by another ticket with Urgent priority and did not make as much progress as I expected. Adding **unit** tests is still a doable alternative. `test_erab_setup_pfcp_establish_error`, `test_erab_setup_pfcp_modify_error`, and `test_erab_release_pfcp_delete_error` are a good example of simulating errors in the unit tests. If you wish, I can take care of this patch, i.e. keep rebasing it and add testing coverage. Let it be my problem then, allowing you to focus on other features. I can try adding a unit test today. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37924?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I242e84fb09b00f4794b6e1aa770f348a0e60aea4 Gerrit-Change-Number: 37924 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 05 Sep 2024 10:24:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>