Attention is currently required from: lynxis lazus, pespin.
1 comment:
Patchset:
I did not expect my request to trigger such an emotional burst...
I do understand your frustration, but this patch introduces significant changes to the core part of the S1GW (the proxy), so this is why I am worried about testing coverage and this is why I am so picky. And TBH, I still don't see how the metrics patch depends on this one and why are they both in the same patch set.
I'm not aware that you followed yourself the same constrains that you are now applying on me [...]
Please understand it's quite frustrating having my patches here for a few days (even a week) and then seeing your recent PFCP patches being pushed and merged quickly without seeing any related TTCN3 tests in gerrit, [...]
This is true, and I acknowledge that the Heartbeat related patches have been merged without the respective TTCN-3 testing coverage. I started working on it, but got swallowed by design/implementation of problems with the PFCP Emulation component.
I just pushed a patchset fixing the emulation component and adding the Heartbeat test:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38037 s1gw: add TC_pfcp_heartbeat
The ttcn3 testsuite is not yet in a state where new tests can easily be added.
I am working on improving the TTCN-3 testsuite. Yes, the progress is slow, but as you know I am not a full time employee and I am working less hours then you. Even worse, I was side tracked by another ticket with Urgent priority and did not make as much progress as I expected.
Adding **unit** tests is still a doable alternative. `test_erab_setup_pfcp_establish_error`, `test_erab_setup_pfcp_modify_error`, and `test_erab_release_pfcp_delete_error` are a good example of simulating errors in the unit tests.
If you wish, I can take care of this patch, i.e. keep rebasing it and add testing coverage.
Let it be my problem then, allowing you to focus on other features.
I can try adding a unit test today.
To view, visit change 37924. To unsubscribe, or for help writing mail filters, visit settings.