Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37553?usp=email ) Change subject: library/GTP_Emulation: Check IMSI presence before returning if Conditional or Optional ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File library/GTP_Emulation.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37553/comment/8b377c87_7633… PS2, Line 121: imsi.digits Is it the `imsi` field that is `optional` and thus can be omitted, or the inner `digits` field? Or maybe both? If it's only the `imsi` field, then I would not check `digits` to avoid confusion. Not critical, but may raise questions. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37553?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I73c683e62191a06212933391d424d608a14f8c1e Gerrit-Change-Number: 37553 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 24 Jul 2024 21:10:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment