[M] Change in osmo-ttcn3-hacks[master]: stp: add testcases for M3UA-over-TCP - gerrit-log

6 Mar 2024

Attention is currently required from: fixeria, pespin.

laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36150?usp=email )

Change subject: stp: add testcases for M3UA-over-TCP
......................................................................

Patch Set 4:

(1 comment)

File stp/STP_Tests_M3UA.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36150/comment/7e7b038f_d8cc… 
PS4, Line 1229: 	f_sleep(1.0);
...
  There is a chance that the random data sent via
`ASP[idx_a]` would reach osmo-stp earlier than the `ASPUP_ACK` we sent for `ASP[idx_b]` --
this is what I was seeing when running `TC_m3ua_tcp_cli_srv`. In this test scenario only
`ASP[idx_b]` is using TCP, and there is some delay likely caused by Nagle's algorithm.

Nagle should IMHO "obviously" be disabled for M3UA over TCP.  IF it is enabled,
that's a bug.  We're not talking about an interactive telnet session here, where
we need to wait for more characters.

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36150?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I1e2a887aa22f317783b3207494fd707d7b426439
Gerrit-Change-Number: 36150
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Comment-Date: Wed, 06 Mar 2024 10:32:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-MessageType: comment