Attention is currently required from: dexter, jolly, tnt.

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/35563?usp=email )

Change subject: Add support for sending and receiving Sa bits, as well as some line signals ......................................................................

Patch Set 4:

(1 comment)

File src/e1_input.c:

https://gerrit.osmocom.org/c/libosmo-abis/+/35563/comment/b4d2ed7d_7d301c31 PS4, Line 1124: { S_L_INP_LINE_LOF, "LINE-LOF" }, : { S_L_INP_LINE_NOLOF, "LINE-NOLOF" }, do we really want to introduce additional signals here? As we can see from the existign list of signals, other hardware typically reports LOS (loss of signal). The icE1usb can't really do that reliably, so that's a hardware constraint. By adding a new signal here you basically require each and every application program to also understand about that new signal.

If we were to report LOF from the driver as LOS to the application, we would be technically incorrect, but we could assume that the applications likely already know to deal with LOS so they don't need codec changes.

What do others think? @pmaier@sysmocom.de @tnt@246tNt.com ?