Attention is currently required from: fixeria, laforge. neels has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-hlr/+/37780?usp=email ) Change subject: subscriber-create-on-demand: add mode for MSISDN=IMSI ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Patchset: PS1: i think it's cool for lab devel, removing one layer of indirection of keeping track which phone has what uSIM. (Also reminds me of reports where Keith told us about how hard it can be in practice to find out the actual IMSI of a device someone holds in your face. So in that particular context it seems silly to use the IMSI.) It's so simple, I'm +1 File include/osmocom/hlr/hlr.h: https://gerrit.osmocom.org/c/osmo-hlr/+/37780/comment/a091ab76_135b12e3?usp… : PS1, Line 46: SUBSCR_COD_MODE_IMSI, just "mode IMSI" wasn't clear to me until I read the code below that copies the IMSI to the MSISDN. Maybe more specific naming based on "mode IMSI-is-MSISDN" or "mode MSISDN-from-IMSI"? (The other mode names have "MSISDN" in the name, so at first reading I thought "what, a randomly generated IMSI??") -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/37780?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I3470492f5e46de7246d9a74e80c37f80f455d851 Gerrit-Change-Number: 37780 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Aug 2024 01:47:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes