Attention is currently required from: neels, pespin.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/32218 )
Change subject: mgcp_codec: fix codec decision ......................................................................
Patch Set 11:
(2 comments)
File src/libosmo-mgcp/mgcp_codec.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/32218/comment/71c22f40_fb53a4a9 PS8, Line 401: * a tentative decision is made.
- ack for dexter. […]
3) The follow up patch makes this more also more precise. When no no codec is chosen for the destination, then then mgcp_patch_pt() would fail and the packet would be tossed (follow up patch).
File src/libosmo-mgcp/mgcp_network.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/32218/comment/fde237f0_67e01d94 PS8, Line 511: rtp_hdr->payload_type = (uint8_t) conn_dst->end.codec->payload_type;
ACK, AFAIU the PayloadType is assigned to a connection, not to an endpoint.
Yes that is correct. (The PayloadType is assigned to a codec and that codec is assigned to a conn)
-
dexter