Attention is currently required from: laforge, dexter.

falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32685 )

Change subject: codec: replace GSM-FR ECU with new implementation ......................................................................

Patch Set 2:

(1 comment)

Patchset:

PS2:

I think review of this patch is slightly more difficult than it should be due to mixing a file rename with introducing new code. Maybe first have a commit doing the rename (purely cosmetic, non-functional) and then a commit that adds the new implementation?

Will do!

Also, I'm not sure if we actually still need to support the direct API that doesn't go through osmo_ecu_ops_fr.

I thought libosmocore policy was to never remove any once-public APIs, only mark them as deprecated - or is it not the case? But in the specific case of the old FR-specific ECU API with publicly exposed state struct, gapk still uses it, and even digs inside struct osmo_ecu_fr_state.