Attention is currently required from: fixeria, laforge, osmith. kirr has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/39327?usp=email ) Change subject: trx_toolkit/clck_gen.py: Fix clock generator not to accumulate timing error ...................................................................... Patch Set 2: (2 comments) Patchset: PS1: Thanks! File src/target/trx_toolkit/clck_gen.py: https://gerrit.osmocom.org/c/osmocom-bb/+/39327/comment/bc41348c_3c838cf5?u… : PS1, Line 98: δt Thanks for feedback, Harald. Well, if you ask for it and since I think it would not be appropriate to push my preferences here, let's indeed change it and avoid greek characters. I changed δt -> dt in the code, and δTxxx -> dΤxxx and μs -> us in the testsuite. Hope it is ok, but please let me know if you really prefer it to be named delta_t and delta_Txxx and I will rework it further. Just for the reference: On Debian GNU/Linux it is easy to input such non-latin symbols with e.g. Fcitx ( https://wiki.debian.org/I18n/Fcitx5 ). Personally I selected 3 languages to be available there (my native, English and Greek) and enjoy ability to use greek letters in texts and code since in many areas of physics, math, applied math and associated programming it is more natural to use greek letters as we were taught at school and universities. Having it being easy to input and uniformly well displayed, as UTF-8 and unicode are widespread and common this days, personally I find using greek letters to be ok and improving readability and signal to noise ratio everywhere. The "delta" spelling comes from the days when people really wanted to represent "δ" but could not, due to e.g. not being able to input it, and/or due to not being able to use non-ASCII characters because of programming language constraints back then. Isn't it? But nowdays those constraints are lifted and using "delta" instead of "δ" is just an inertia, I think. Anyway I shared all that just for the reference and if you really prefer to use the "delta" style, so be it that way here. Thanks, once again, for feedback, Kirill -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/39327?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I928801422c9af80c368261f617b91d7ecfedbabf Gerrit-Change-Number: 39327 Gerrit-PatchSet: 2 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 Jan 2025 11:31:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: kirr <kirr(a)nexedi.com> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>