Attention is currently required from: fixeria.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35322?usp=email )

Change subject: mgcp: reserve once byte for '\0' in mgcp_do_read() ......................................................................

Patch Set 1:

(1 comment)

File src/libosmo-mgcp-client/mgcp_client.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/35322/comment/7ed6bf89_cfba5ec4 PS1, Line 762: ret = read(fd->fd, msg->data, msgb_tailroom(msg) - 1); I'd say the proper way would be to use msgb_failroom(msg) here, and then msg->l2h[OSMO_MIN(ret, msgb_l2len(msg))] = '\0' later, to put the char at the exact place where the last char is set.