Attention is currently required from: pespin.
laforge has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39767?usp=email )
Change subject: sccp: Improve logging receiving unexpected msg
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File sccp/SCCP_Tests_RAW.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39767/comment/6f0a31d4_b2e4…
:
PS2, Line 154: {
: Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail,
: log2str("Unexpected MTP/SCCP received: got
(ASP_MTP3_PAUSE|ASP_MTP3_RESUME|ASP_MTP3_STATUS) vs exp ", exp
this is a bit "unelegant" as it basically is the default case. Todays M3UA
implementation may just know of ASP_MTP3_{PAUSE,RESUME,STATUS} but that might of course
change at whcih point the code here is no longer valid. Not critical, just saying...
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39767?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I90c5236882e96fc038fee0d2f4551cfc58767c78
Gerrit-Change-Number: 39767
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 11 Mar 2025 16:15:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes