Attention is currently required from: jolly, neels.
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34985?usp=email )
Change subject: LAPD: Add support for RTS based polling and T200 ......................................................................
Patch Set 9:
(2 comments)
File src/isdn/lapd_core.c:
https://gerrit.osmocom.org/c/libosmocore/+/34985/comment/956b985c_79614f74 PS9, Line 1939: if ((dl->lapd_flags & LAPD_F_RTS) && !llist_empty(&dl->tx_queue)) { This looks a bit weird. You return here if !llist_empty() (and RTS), but in lapd_ph_rts_ind() you call this function only if llist_empty().
I might be missing something, I'm not really familiar with this code.
https://gerrit.osmocom.org/c/libosmocore/+/34985/comment/a2231539_1c716b12 PS9, Line 1945: next_frame: Irrelevant for this patch, but this label really should be unindented.