Attention is currently required from: laforge.
dexter has posted comments on this change by dexter. (
https://gerrit.osmocom.org/c/pysim/+/37895?usp=email )
Change subject: pySim-shell, cosmetic: define positional arguments last
......................................................................
Patch Set 2:
(1 comment)
File pySim-shell.py:
https://gerrit.osmocom.org/c/pysim/+/37895/comment/9e777c8f_33725b6e?usp=em… :
PS1, Line 238: apdu_cmd_parser = argparse.ArgumentParser()
is this really a cosmetic change? I would expect that
before this change, the --opts would have to […]
To my experience this will not
change the command syntax. To my experience it does not matter if positional arguments
come first or last. I have tested it now again:
apdu 00a40004023f00 --expect-sw 9000
apdu --expect-sw 9000 00a40004023f00
both commands work the same. I also tried it out manually with some python code. The
result is the same.
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/37895?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I2412eb6e7dc32ae95a575f31d4489ce210d85ea0
Gerrit-Change-Number: 37895
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Fri, 23 Aug 2024 15:36:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>