fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38099?usp=email )
Change subject: s1gw: move t_ConnHdlrPars back to S1GW_Tests ......................................................................
Patch Set 1:
(1 comment)
File s1gw/S1GW_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38099/comment/2398e411_5ccdd... : PS1, Line 168: var ConnHdlrPars pars := valueof(t_ConnHdlrPars);
I really don't see why you prefer having a valueof(t_ConnHdlrPars) instead of an already in place fu […]
It's not about having `valueof(t_ConnHdlrPars)` vs `f_new_ConnHdlrPars()`, it's about the burden of adding new parameters in several places. Doesn't really matter if it's a function of a template, since I just copy-paste the testcase template anyway rather than typing all the `f_init()`-stuff manually.
-
fixeria