fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38099?usp=email ) Change subject: s1gw: move t_ConnHdlrPars back to S1GW_Tests ...................................................................... Patch Set 1: (1 comment) File s1gw/S1GW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38099/comment/2398e411_5ccd… : PS1, Line 168: var ConnHdlrPars pars := valueof(t_ConnHdlrPars); It's not about having `valueof(t_ConnHdlrPars)` vs `f_new_ConnHdlrPars()`, it's about the burden of adding new parameters in several places. Doesn't really matter if it's a function of a template, since I just copy-paste the testcase template anyway rather than typing all the `f_init()`-stuff manually. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38099?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibc34d0219a616a239c0595e61a783f18fbc91b36 Gerrit-Change-Number: 38099 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 13 Sep 2024 01:21:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>